Fix bug where domains aren't re-entered when handlers are executed #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's the one labeled "This tests if promise domain membership infects subscriptions made in handlers." The inner handler wasn't ever executing, due to some kind of circularity I think. Not sure. Now it's executing but not with the right promise domain (meaning promise domain reentry isn't happening).
When a handler is subscribed to a promise (using then() or similar) and a promise domain is active, then when the handler is invoked, the promise domain should be made active again. This allows the domain to "infect" handlers that are registered later, but in the same scope.
|
WARNING: Some of these async tests can fail and not fail testthat, resulting in blue checks! Example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tidyverse/elmer#163