You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current regexps for identifying YouTube and Vimeo links are designed to find links that are known candidates. For example, the YT regexp is good for extracting the embed ID from a known probable YT link. They don't however, include some baseline checks such as checking that the link is an https? link. It would be unusual, but it's still possible that something not intended to be used as a YT link (a base64-encoded image, for example) could be picked out as a YT link.
Our docs state that the whole link should be used, so I think it'd be okay for us to add in ^http to the regexp. Alternatively, we could find a more robust regular expression.
The text was updated successfully, but these errors were encountered:
The current regexps for identifying YouTube and Vimeo links are designed to find links that are known candidates. For example, the YT regexp is good for extracting the embed ID from a known probable YT link. They don't however, include some baseline checks such as checking that the link is an
https?
link. It would be unusual, but it's still possible that something not intended to be used as a YT link (a base64-encoded image, for example) could be picked out as a YT link.learnr/learnr-js/tutorial/tutorial.js
Lines 404 to 405 in 1c01ac2
Our docs state that the whole link should be used, so I think it'd be okay for us to add in
^http
to the regexp. Alternatively, we could find a more robust regular expression.The text was updated successfully, but these errors were encountered: