Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC][TUTO] Merge fixes for quick-start step3/4 according to truffle/ganache changes #597

Draft
wants to merge 35 commits into
base: master
Choose a base branch
from

Conversation

rcoscali
Copy link
Contributor

@rcoscali rcoscali commented May 8, 2021

What

  • Change steps 3&4 according to truffle/ganache updates

Why

  • Because of issue Re organize menus #6 on rsksmart/truffle-integration repo, truffle and ganache have to be used in the last release
  • Step2 have been changed accordingly then now step3 & step4
  • Add resume at top of each page to be consistent accross tuto
  • Fix some minor inconsistencies in miscellaneous places

Refs

rcoscali and others added 23 commits May 8, 2021 12:48
Added resume from step 2
Added <tutorial-root> in cd command to be consistent with previous pages
Changed images for step 4 of quick start tuto according to new ganache version
Updated ganache workflow and screenshots for version 2.5.4
Updated use contract for openzeppelin ones
Modified the migration script accordingly
Renamed misnamed Enter-ganache.png.png
Links are pointing towards sol files when truffle-integration PR will be merged
Updated source code for deployer
Remove some of the contract source
Remove used params for token deployment
Updated smart contract
@owans owans requested a review from bguiz May 12, 2021 19:18
rcoscali and others added 6 commits May 14, 2021 16:37
Added npm install command for OpenZeppelin library
Highlighted the solc version requirement through solidity pragma.
Fixed markdown tag for figure
Updated sol source link to patch one
Fixed again xD markdown tag (I'm really not friend with us)
Last inversion of links (I hope ...)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant