Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Deprecation noticed in the docs. #1049

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wise4rmgodroot
Copy link

What

  • (describe the changes)

Why

  • (the reason these changes are wanted)
  • (if this patch addresses and existing, feel free to copy this section across)

Refs

  • (optional: include links to other issues, PRs, tickets, etc)

Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
devportal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 9:24am

@owans
Copy link
Collaborator

owans commented Jul 12, 2024

Kindly add a description for this, and link to the task. @wise4rmgodroot

@@ -8,6 +8,10 @@ layout: rsk
---


> We regret to inform you that the Liquality Wallet has been discontinued. To continue managing your assets seamlessly, we encourage you
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This intro doesn't seem appropriate. Liquality is not an internal tool but a partner tool, so we can't use the term "regret".

You can refer to previous dep notices or use the exact terms in the blog post about alternative wallets

@@ -8,6 +8,11 @@ layout: rsk
---
![2 way peg app (peg-out)](/assets/img/guides/two-way-peg-app/pegout.gif)


> We regret to inform you that the Liquality Wallet has been discontinued. To continue managing your assets seamlessly, we encourage you
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, decide which is the best page to write the notice, keep the notice on that page, and refer the reader to a link to read more on why Liquality will be deprecated in the main page.

Additionally, refer to one or two actual wallets before linking to the external blog post.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didnt provide much info on why Liquality will be deprecated in the main page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants