Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent generated toolpaths using surface_raster_planner_demo.launch #103

Open
dave992 opened this issue Aug 14, 2020 · 6 comments
Open

Comments

@dave992
Copy link

dave992 commented Aug 14, 2020

Based on my understanding of Noether, it should generate a toolpath in a deterministic way. Therefore recalculating the toolpath should always return the same result.

When running the surface_raster_planner_demo.launch the results vary, here are some screenshots of what I mean:

Screenshot from 2020-08-13 15-31-35 Screenshot from 2020-08-13 15-33-38
Screenshot from 2020-08-13 15-38-45 huge_arrow_noether_example

The 'main' toolpaths seem to be recalculated correctly, but some additional clusters seem to appear/disappear on different runs.

  • The top left image shows an additional group of (purple) markers on the edge on the bottom middle part of the mesh. Furthermore, an additional path is generated left from the hole in the mesh, between the top and bottom paths (blue/purple markers) . This additional middle path is not perpendicular to the surface.
  • The top right image shows again the additional group of (purple) markers on the edge on the bottom middle part of the mesh, but this time in a different orientation than the previous image. Additionally, there is group of markers on the bottom right corner of the mesh, which can be hard to see as the markers are not that big and also colored red (as the mesh).
  • The bottom left image shows the generated toolpath as I would expect.
  • The bottom right image shows a single large arrow. The mesh itself and the expected toolpaths are visible at the base of the arrow but this can be somewhat hard to see as a result of the scale difference.

Using different meshes also results in similar behavior.

To reproduce (It may take several tries to produce different results):

  1. roslaunch noether_examples surface_raster_planner_demo.launch
  2. Close window or kill process
  3. Repeat

This was run on Ubuntu 18.04/ROS Melodic with VTK 7.1.1 and PCL 1.9.1.

@gavanderhoorn
Copy link
Member

@dave992: could you perhaps also specify what version of Noether you are seeing this with (ie: commit hash)?

@dave992
Copy link
Author

dave992 commented Aug 14, 2020

Both PC's I encountered this issue on were using version 47d7472.

@gavanderhoorn
Copy link
Member

@Levi-Armstrong: is this something you've ran into perhaps?

We're willing to debug this ourselves, just looking to avoid spending effort in case it's a known issue.

@Levi-Armstrong
Copy link
Member

@jrgnicho @DavidMerzJr @drchrislewis you all probably have used it the most. Do you have any insights into what they are experiencing? My first thoughts are it should be, at least for the first raster, but then it does some offsetting to create equal surface distance lines which may not be deterministic.

@gavanderhoorn
Copy link
Member

We were also thinking it may be using some uninitialised memory somewhere. Especially the screenshot in the bottom-right made me suspicious.

@mpowelson
Copy link
Contributor

mpowelson commented Aug 25, 2020

We were also thinking it may be using some uninitialised memory somewhere. Especially the screenshot in the bottom-right made me suspicious.

I remember thinking the same thing wrid19 when we had some unit tests that would pass on one run and fail the next if run repeatedly. Probably unrelated, but here is the issue

@marip8 marip8 mentioned this issue Jun 22, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants