Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spinOnce is blocking and isReadyReceive is protected #63

Open
GoogleCodeExporter opened this issue Apr 7, 2015 · 1 comment
Open

spinOnce is blocking and isReadyReceive is protected #63

GoogleCodeExporter opened this issue Apr 7, 2015 · 1 comment

Comments

@GoogleCodeExporter
Copy link

The spinOnce method of MessageManager is blocking if no messages are currently 
available to process.  Since the purpose of such a method is generally to run 
in realtime critical time slices, such behavior probably needs to be 
redesigned.  A useful workaround seems to be preceding the call with a 
"if(connection.isReadyReceive(0))".  However, calling this explicitly under the 
current code base is impossible since the method is protected.  In my code, I 
have modified the call to be public.

Original issue reported on code.google.com by kphawk...@gmail.com on 23 May 2013 at 3:52

@GoogleCodeExporter
Copy link
Author

Good catch.  You change seems appropriate (making that function public won't 
hurt anything).  Could you please update the header file comment to reflect the 
actual behavior of the function (i.e. non blocking when zero is passed, it 
currently says the opposite).

Original comment by shaun.ed...@gmail.com on 23 May 2013 at 7:13

  • Added labels: Package-Simple_Message, Priority-High, Release-Hydro
  • Removed labels: Priority-Medium

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant