Skip test

ropensci · Oct 5, 2023 · 95826cd · 95826cd
1 parent ff941a5
commit 95826cd
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.github/workflows/R-CMD-check.yaml b/.github/workflows/R-CMD-check.yaml
@@ -29,7 +29,7 @@ jobs:
       R_KEEP_PKG_SOURCE: yes
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
       - uses: r-lib/actions/setup-pandoc@v2
 

diff --git a/NEWS b/NEWS
@@ -1,3 +1,6 @@
+3.0.3
+  - Skip a test on MacOS because of buggy iconv in Sonoma
+
 3.0.2
   - Find paths to dictionaries of RStudio 1.3.x and 1.4.x (@GegznaV, #42)
 

diff --git a/tests/testthat/test-encodings.R b/tests/testthat/test-encodings.R
@@ -39,7 +39,6 @@ test_that("UTF8 always works", {
   expect_equal(length(hunspell_find(str1, dict = "russian-aot")[[1]]), 0)
   expect_equal(hunspell_find(str3, dict = "en_US")[[1]], str3)
   expect_equal(hunspell_find(str3, ignore = str3, dict = "en_US")[[1]], character(0))
-  expect_warning(hunspell_find(str3, dict = "russian-aot"), "encoding")
   expect_equal(hunspell_parse(str4)[[1]][2], str2)
   expect_equal(hunspell_parse(str4)[[1]][7], str3)
 
@@ -56,6 +55,9 @@ test_that("UTF8 always works", {
   expect_match(hunspell_analyze(str2, dict = "russian-aot")[[1]][1], stemstr)
   expect_match(hunspell_analyze(str2, dict = "ru_RU")[[1]][1], stemstr)
 
+  # iconv on macos 14 seems broken, retuns '?' instead of error
+  skip_on_os('mac')
+  expect_warning(hunspell_find(str3, dict = "russian-aot"), "encoding")
 })
 
 test_that("custom words in dictionary",{