Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posting review comments fails with Reviews 2.0 #133

Open
rombert opened this issue May 8, 2014 · 2 comments
Open

Posting review comments fails with Reviews 2.0 #133

rombert opened this issue May 8, 2014 · 2 comments
Assignees
Labels
Milestone

Comments

@rombert
Copy link
Owner

rombert commented May 8, 2014

!ENTRY org.eclipse.ui 4 0 2014-05-09 00:38:44.506
!MESSAGE Unhandled event loop exception
!STACK 0
java.lang.ClassCastException: org.review_board.ereviewboard.core.ReviewboardRepositoryConnector cannot be cast to org.eclipse.mylyn.reviews.core.spi.ReviewsConnector
    at org.eclipse.mylyn.internal.reviews.ui.dialogs.AddCommentDialog.performOperation(AddCommentDialog.java:140)
    at org.eclipse.mylyn.internal.reviews.ui.dialogs.AddCommentDialog.close(AddCommentDialog.java:83)
    at org.eclipse.jface.dialogs.Dialog.okPressed(Dialog.java:940)
    at org.eclipse.jface.dialogs.Dialog.buttonPressed(Dialog.java:472)
    at org.eclipse.mylyn.reviews.ui.ProgressDialog.access$1(ProgressDialog.java:1)
    at org.eclipse.mylyn.reviews.ui.ProgressDialog$2.widgetSelected(ProgressDialog.java:265)
    at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:240)
    at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1258)
    at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3588)
    at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3209)
    at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
    at org.eclipse.jface.window.Window.open(Window.java:801)
    at org.eclipse.mylyn.internal.reviews.ui.actions.AddLineCommentToFileAction.run(AddLineCommentToFileAction.java:119)
    at org.eclipse.mylyn.internal.reviews.ui.actions.AbstractReviewAction.run(AbstractReviewAction.java:49)
    at org.eclipse.ui.actions.BaseSelectionListenerAction.runWithEvent(BaseSelectionListenerAction.java:168)
    at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
    at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
    at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
    at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1258)
    at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3588)
    at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3209)
    at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2701)
    at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2665)
    at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2499)
    at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:679)
    at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
    at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:668)
    at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
    at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:123)
    at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke(Method.java:597)
    at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
    at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
    at org.eclipse.equinox.launcher.Main.run(Main.java:1410)
    at org.eclipse.equinox.launcher.Main.main(Main.java:1386)```
@rombert rombert added this to the 0.14.0 milestone May 8, 2014
@rombert rombert added the defect label May 8, 2014
@rombert rombert self-assigned this May 8, 2014
@rombert rombert modified the milestones: 0.13.3, 0.13.4 Oct 19, 2014
@rombert rombert modified the milestones: 0.13.4, 0.13.5 Feb 19, 2017
@gyurma5th
Copy link

Is something preventing it to make ReviewboardRepositoryConnector a ReviewsConnector (except the lot of changes it causes)?
I will try to go after this if you do not object.

@rombert
Copy link
Owner Author

rombert commented Nov 15, 2017

@gyurma5th - no objections from me, feel free to give it a go :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants