Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement - consider packaging module loading #426

Open
digitaltrails opened this issue Jun 2, 2024 · 2 comments
Open

Enhancement - consider packaging module loading #426

digitaltrails opened this issue Jun 2, 2024 · 2 comments
Labels

Comments

@digitaltrails
Copy link

When I packaged ddcutil-service for OpenSUSE, I was advised to add module loading to the spec so that users would not have to deal with that themselves.

I added the following to the ddcutil-service.spec:

# Module loading on subsequent boots
install -m 0644 -D -t %{buildroot}%{_prefix}/lib/modules-load.d/ i2c-dev/%{name}.conf

# Module load for the current boot:
# The post modprobe is helpful for the user, but not really necessary, don't error if it fails
%post
%{_prefix}/sbin/modprobe i2c-dev ||:

You might like to consider whether ddcutil or ddcui should do something similar. Or whether this might be bundled in with the i2c rules package.

@rockowitz rockowitz added enhancement building problems building ddcutil distribution labels Jun 5, 2024
@rockowitz
Copy link
Owner

make install has done this since ddcutil release 2.0.0 and ddcui 0.5.4 See the [release notes](http://www.ddcutil.com/release_notes/#installation and ddcui release notes. Whether the distribution packages (rpm, deb, etc.) install the file depends on the distribution and its procedures. I supply the official debian packages which does this (or more precisely will do so once the packages are updated to the current version.

@digitaltrails
Copy link
Author

This issue can therefore be closed?

In my case, I should raise this as an issue with the OpenSUSE package/maintainer on OpenSUSE build system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants