-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Walking-controller expanded with navigation features #142
Comments
Another thing to discuss is how to handle different config parameters from the planner side (also PID values) that I have changed for my simulation. |
Hi @SimoneMic, thanks for opening the issue. I would say it is a bit hard to provide comments based on the numbered list. A PR would be the best place to discuss about the code I would say. I have seen you have opened #143 but there are many conflicts, and the PR dimension is not negligible. Would you be able to split it into smaller PRs? Also, it seems that you have been working on a fork of https://github.com/robotology/unicycle-footstep-planner. Since this is a dependency of |
Hi I will separate it into different PRs. The next one will need changes of the |
Hello
I am opening this issue to illustrate the changes that I've made to the walking controller for enabling the communication with the navigation stack.
The main files impacted are the
Module
andTrajectoryGenerator
m_FKSolver
, the other publishes the replanning trigger to the navigation stack (i.e. when to plan a new path).This issue is mainly for discussion, also because the code could be improved based on your needs and styles.
The text was updated successfully, but these errors were encountered: