Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoding results suppose a structure of results. #83

Open
4 tasks
robbisg opened this issue Oct 18, 2021 · 0 comments
Open
4 tasks

Decoding results suppose a structure of results. #83

robbisg opened this issue Oct 18, 2021 · 0 comments
Labels
bug Something isn't working implementation All that concerns software choices from implementation POV

Comments

@robbisg
Copy link
Owner

robbisg commented Oct 18, 2021

The Decoding object hypothesize results in a dict with rois.
This should be moved to RoiWrapper and use Decoding only for simple decoding results.

We should take into account the RoiDecoding object or other objects that inherit from Decoding superclass.

RoiDecoding must have a self.analysis.save call to move the responsibility to wrapped class and it should save

TODO:

  • Remove for in Decoding.save
  • Move for in RoiDecoding.save
  • Wrappers must record objects for each ROI
  • We can pass to save also scores and save passed scores.
@robbisg robbisg added bug Something isn't working implementation All that concerns software choices from implementation POV labels Oct 18, 2021
@robbisg robbisg changed the title Decoding results suppose the a structure of results. Decoding results suppose a structure of results. Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working implementation All that concerns software choices from implementation POV
Projects
None yet
Development

No branches or pull requests

1 participant