enableMarkdownInDescription does not work in parent elements of if description is above input element

[quazgar]

Prerequisites

• I have searched the existing issues
• I understand that providing a SSCCE example is tremendously useful to the maintainers.
• I have read the documentation
• Ideally, I'm providing a sample JSFiddle, Codesandbox.io or preferably a shared playground link demonstrating the issue.

What theme are you using?

material-ui

Version

5.x / current playground

Current Behavior

As demonstrated in this playground instance, enableMarkdownInDescription only seems to work in leaf nodes, not in higher levels of the json schema tree.

Expected Behavior

enableMarkdownInDescription should work everywhere.

Steps To Reproduce

Option 1: Look ath the playground example linked above.

Option 2:

1. Add "ui:enableMarkdownInDescription": true to the ui schema definition in an element which has children.
2. Add a description which should be rendered as Markdown.

Environment

Current playground.

Anything else?

No response

[quazgar]

@dejanbelusic @heath-freenome ping, because you seem to have been involved in #3665

[heath-freenome]

@quazgar Good catch. I'm really busy and I do not have time to make a fix. If @dejanbelusic is unable to help, would you be willing to provide a PR to fix this?

[quazgar]

I am pretty busy myself, but maybe I can find a customer who needs this and is willing to pay, or a colleague might find the time.

[quazgar]

New playground instance which shows that markdown also does not seem to work for descriptions which render above the input element (a boolean field in this case).

Schema

{
  "title": "A list of tasks",
  "type": "object",
  "properties": {
    "tasks": {
      "description": "*very* simple, but no Markdown",
      "type": "object",
      "title": "Tasks",
      "properties": {
        "details": {
          "type": "string",
          "title": "Task details",
          "description": "Description which renders Markdown *correctly*."
        },
        "has_Markdown": {
          "type": "boolean",
          "description": "Also *no Markdown*"
}}}}}

UI schema

{
  "tasks": {
    "ui:enableMarkdownInDescription": true,
    "ui:description": "New *description*, still no Markdown.",
    "details": {
      "ui:enableMarkdownInDescription": true,
      "ui:widget": "textarea"
    },
    "has_markdown": {
      "ui:enableMarkdownInDescription": true
}}}

[dejanbelusic]

Hi @heath-freenome, I created a PR fixing this issue: #4405, you can take a look!

Hi @quazgar, sorry it took me this long to tackle this issue. I wish I could have done it sooner, hope it still brings you value.

[dejanbelusic]

New playground instance which shows that markdown also does not seem to work for descriptions which render above the input element (a boolean field in this case).

Schema

{
  "title": "A list of tasks",
  "type": "object",
  "properties": {
    "tasks": {
      "description": "*very* simple, but no Markdown",
      "type": "object",
      "title": "Tasks",
      "properties": {
        "details": {
          "type": "string",
          "title": "Task details",
          "description": "Description which renders Markdown *correctly*."
        },
        "has_Markdown": {
          "type": "boolean",
          "description": "Also *no Markdown*"
}}}}}

UI schema

{
  "tasks": {
    "ui:enableMarkdownInDescription": true,
    "ui:description": "New *description*, still no Markdown.",
    "details": {
      "ui:enableMarkdownInDescription": true,
      "ui:widget": "textarea"
    },
    "has_markdown": {
      "ui:enableMarkdownInDescription": true
}}}

In the example you shared here, please note that in Shema you are using has_Markdown, but in UI schema it says has_markdown. These values are case-sensitive and should be the same. Please note that when testing the feature after my PR gets merged.