-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A vector of sideband signals to inform the trace output being stopped #98
Comments
I propose we call this signal ''notrace". |
Yeah, seems like bit 0 shouldn't be called halted anymore, since for the reserved 0b11 case we may not be halted. I might lean towards "traceinh[1:0]", but don't care that much. One trick with this is that an implementation can't simply connect bit 0 to halted and bit 1 to security check failure. Otherwise the encoder could see 0b11 when the hart is both halted and security checks fail (e.g., we halted in M-mode but trace is not allowed in M-mode). The table above is clear enough, but the external debug spec probably needs clarification here. |
Agree - we need a new name for the new vector, not a new signal that has an encoded meaning with halted. That’s a recipe for screw ups.
I guess you’re thinking “trace inhibit”? I don’t think we need “trace” in the name of the ingress port signal - they’re all for trace! So we could just go with “inhibit”? I prefer that to traceinh as it’s not so obvious to the casual reader what “inh” means.
…________________________________
From: Beeman Strong ***@***.***>
Sent: Tuesday, June 4, 2024 6:14:25 PM
To: riscv-non-isa/riscv-trace-spec ***@***.***>
Cc: Robertson, Iain (DI SW ICS TST RD EAH) ***@***.***>; Assign ***@***.***>
Subject: Re: [riscv-non-isa/riscv-trace-spec] A vector of sideband signals to inform the trace output being stopped (Issue #98)
Yeah, seems like bit 0 shouldn't be called halted anymore, since for the reserved 0b11 case we may not be halted. I might lean towards "traceinh[1:0]", but don't care that much.
One trick with this is that an implementation can't simply connect bit 0 to halted and bit 1 to security check failure. Otherwise the encoder could see 0b11 when the hart is both halted and security checks fail (e.g., we halted in M-mode but trace is not allowed in M-mode). The table above is clear enough, but the external debug spec probably needs clarification here.
—
Reply to this email directly, view it on GitHub<#98 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALQOPSWW2JNW5A3B2SDVUADZFXRWDAVCNFSM6AAAAABF6FFB6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBXHEZDAOJSHA>.
You are receiving this because you were assigned.Message ID: ***@***.***>
|
good point, inhibit works |
Based on discussion on external debug security TG meeting, adding another bit alongside halted signal to bundle a vector is the desired way to inform the trace to stop output due to different reasons. The reserved encoding is for futural extension.
The text was updated successfully, but these errors were encountered: