Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label deprecated in Code based for measures but we still use in the UI #6140

Open
royendo opened this issue Nov 22, 2024 · 3 comments
Open
Assignees
Labels
nit Nit Issue Type

Comments

@royendo
Copy link
Contributor

royendo commented Nov 22, 2024

Describe the bug
Are we using Label or Display Name moving forward, UI and YAML are incosistent

Label string // Deprecated: use display_name

Expected behavior
Change the UI to Display Name for less confusion

Screenshots
Screenshot 2024-11-22 at 14 26 28

@royendo royendo added the nit Nit Issue Type label Nov 22, 2024
@mindspank
Copy link
Contributor

The actual display columns needs changing but we should also:

  • Map to display_name key in yaml files
  • For metric views that was created pre-deprecation we should "migrate" a measure or dimension to use display_name instead of title/label when edited.

@ericpgreen2
Copy link
Contributor

To confirm, is the UI supposed to read "Display name" not "Label"? @jkhwu

@mindspank
Copy link
Contributor

Yes, as per design mocks its Display name.
We have also deprecated the actual yaml property label and title in favour of display_name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nit Nit Issue Type
Projects
None yet
Development

No branches or pull requests

4 participants