Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation]: Mention getErrorCode in upgrading section #245

Open
1 task done
levicki opened this issue Sep 18, 2024 · 3 comments
Open
1 task done

[Documentation]: Mention getErrorCode in upgrading section #245

levicki opened this issue Sep 18, 2024 · 3 comments
Assignees
Milestone

Comments

@levicki
Copy link

levicki commented Sep 18, 2024

Feature description

The upgrading section here does not mention that BitException no longer has getErrorCode() and what it has been replaced with.

Additional context

No response

Code of Conduct

@levicki levicki changed the title [Documentation]: [Documentation]: Mention getErrorCode in upgrading section Sep 18, 2024
@rikyoz
Copy link
Owner

rikyoz commented Sep 19, 2024

Hi!
You are right, I forgot to add this change to the list.
Thanks for pointing this out, I will update the README as soon as possible!

@levicki
Copy link
Author

levicki commented Sep 19, 2024

@rikyoz No worries man, I upgraded my project from 3.1.1 to 4.0.8 without a hitch. I hope you are doing fine, thanks again for writing this library.

@rikyoz
Copy link
Owner

rikyoz commented Sep 22, 2024

I upgraded my project from 3.1.1 to 4.0.8 without a hitch.

Glad to hear the upgrade went smoothly!

I hope you are doing fine, thanks again for writing this library.

Thank you for your kind words! I'm doing well, hope you are too.
Thanks for keeping using bit7z! 🙏

rikyoz added a commit that referenced this issue Sep 29, 2024
@rikyoz rikyoz added this to the v4.0.9 milestone Nov 2, 2024
rikyoz added a commit that referenced this issue Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants