Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can't update dynamic title #1

Open
jzambrano12 opened this issue Jun 6, 2019 · 1 comment
Open

I can't update dynamic title #1

jzambrano12 opened this issue Jun 6, 2019 · 1 comment
Labels

Comments

@jzambrano12
Copy link

I'm trying to use react-sortable-hoc with this library, but when I update the titles extracted from Redux it doesn't change them, but it changes the content and everything else.

Researching a little the library I realized that within its functions does not have a shouldComponentUpdate to update its state ... As far as I can see, the state is correctly brought in the first rendering, but when it changes, the state doesn't change.

@rijulaggarwal16 rijulaggarwal16 added bug and removed bug labels Jun 10, 2019
@rijulaggarwal16
Copy link
Owner

Thanks @jzambrano12 for bringing it up.

It seems to be a problem. I'll work on it, or you could submit a PR too if you wish so.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants