Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional CCS matching? #61

Open
michaelwitting opened this issue Feb 19, 2022 · 6 comments
Open

Additional CCS matching? #61

michaelwitting opened this issue Feb 19, 2022 · 6 comments

Comments

@michaelwitting
Copy link
Collaborator

More and more people use ion mobility and my question is if we should also add CCS matching?
Could be done in matchMz with an additional param object. Matching would be m/z and CCS or m/z, RT and CCS.

@jorainer
Copy link
Member

Sounds good to me. But we would need test data etc for that...

@michaelwitting
Copy link
Collaborator Author

I have some data, no problem. I will search for it. CCS matching is typically done with a relative error in %.

@michaelwitting
Copy link
Collaborator Author

One important thing that came to my mind: We only need MzCcsParam and MzRtCssParam. Each adduct has a different CCS-value, therefore the conversion from exact mass to m/z makes no sense.
How shall we go from here? Shall I implement a prototype?

@jorainer
Copy link
Member

sorry for my late reply. Yes, please go ahead and implement a prototype. I would suggest to maybe implement that in a separate file (MzCcsParam.R or similar)? The matchValues.R file gets already quite large and unreadable.

@michaelwitting
Copy link
Collaborator Author

Wrong issue? @chufz I think you wanted answer to the timsTOF backend right?

@chufz
Copy link

chufz commented Mar 29, 2022

yes sorry- too many open tabs...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants