You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
call into layout_from_lsh_forest with a zero-size LSHForest
observe a crash when de-referencing an invalid end-iterator
The cause seems to be float max_x = *max_element(x.begin(), x.end()); where we dereference the invalid end-iterator returned by max_element when called with an empty container. This should crash more often, but although I've not looked into it properly, but because we dereference into a float we probably just get garbage data on the other platforms.
I have a fix for this code path and MSTFromLSHForest where we return an tuple of empty objects for an empty forest. The fix is on the development branch.
The text was updated successfully, but these errors were encountered:
Repo:
layout_from_lsh_forest
with a zero-sizeLSHForest
The cause seems to be
float max_x = *max_element(x.begin(), x.end());
where we dereference the invalid end-iterator returned bymax_element
when called with an empty container. This should crash more often, but although I've not looked into it properly, but because we dereference into a float we probably just get garbage data on the other platforms.I have a fix for this code path and
MSTFromLSHForest
where we return an tuple of empty objects for an empty forest. The fix is on the development branch.The text was updated successfully, but these errors were encountered: