Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish binaries/artifacts with releases #114

Open
elmarx opened this issue Oct 20, 2023 · 2 comments
Open

Publish binaries/artifacts with releases #114

elmarx opened this issue Oct 20, 2023 · 2 comments

Comments

@elmarx
Copy link
Member

elmarx commented Oct 20, 2023

We do not yet upload binaries from the GHA, it would be ideal to do that with releases/tags.

@rd-robert-avram
Copy link

rd-robert-avram commented Oct 20, 2023

There's one thing that I had stumbled upon, which I don't know if you are aware of.
In our current setup, we package a locally built binary of schema2000 together with all the rest of our crud in a docker image.

We later realised that the version of glibc, with which schema2000 was built, is crucial to its runnability.
If the OS you run it on has a glibc version < than the OS that built it => it will not work.
Might be a thing to take into account when building the binary.

@elmarx
Copy link
Member Author

elmarx commented Nov 14, 2023

I looked how other rust projects do binary distributions, and it seems the typical approach for "static linking" is to link against musl.

A good example I came across lately is https://github.com/scarvalhojr/aoc-cli/blob/main/.github/workflows/release.yml, we can probably take that as guid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants