Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

badge: pt_BR for KitsuShiro #263

Closed
2 tasks done
YoshiroOno opened this issue Aug 18, 2023 · 4 comments
Closed
2 tasks done

badge: pt_BR for KitsuShiro #263

YoshiroOno opened this issue Aug 18, 2023 · 4 comments
Labels
status: approved All of the relevant maintainers have approved this request.

Comments

@YoshiroOno
Copy link

YoshiroOno commented Aug 18, 2023

What language(s) did you translate?

Brazilian Portuguese

What is your Revolt ID?

01H84AH6MMVPJDQ8RGD6YE0SBE

Link to Weblate profile

https://translate.revolt.chat/user/KitsuShiro/

Validations

  • The language has a maintainer (see the full list here).
  • You agree that your translations are to a reasonable standard.
@Rexogamer
Copy link
Member

cc @yanndere

@Rexogamer Rexogamer added the status: pending The relevant maintainers have not responded yet. label Aug 19, 2023
@YoshiroOno
Copy link
Author

he does not seem to be actively accessing github, only weblate.

@ghost
Copy link

ghost commented Aug 23, 2023

Thanks for contributing to the Brazilian translation.
I've analyzed the strings you sent to the Web App component and I approve your badge request.

There are some points which I would like to mention, though:

Important

Inconsistency: You sent different translations for the same text (same context).
This was seen in 8 unique strings, most of them (7) referring to client settings.

If this is (enabled/disabled):

  • Se essa opção estiver
  • Se isso estiver
  • Se isso for

I also found other inconsistencies, but I hope we can discuss those on Revolt.

Note

Lack of communication: I removed one of the suggestions you sent and even provided the reason. I also added a translation comment right after. Some hours later you made the same suggestion without providing further details. Although this was a minor issue, communication is very important if we are going to work as a team.

@YoshiroOno
Copy link
Author

sure, I'll keep an eye out for these details.

I considered the understandability of the users at the time I was translating, so at some point there was a mismatch, because I didn't check the string in which it was attached.

@Rexogamer Rexogamer added status: approved All of the relevant maintainers have approved this request. and removed status: pending The relevant maintainers have not responded yet. labels Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: approved All of the relevant maintainers have approved this request.
Projects
Archived in project
Development

No branches or pull requests

2 participants