CI enhancement: docker workflow speedup #2232
Merged
+37
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aradwann
force-pushed
the
ci-docker-enhancement
branch
from
d82aab9
to
1efcc88
Compare
aradwann
force-pushed
the
ci-docker-enhancement
branch
from
c932e84
to
e01a2e9
Compare
show sccache stats update cache from/to config try to optimize dockerfile fix dockerfile fix chef command try to use sccache directory of the gh runner enable debug logs for sccache use build context to mount runner sccache to container sccache fix typo update sccache dir update target destination test test test test test test debug revert dockerfile changes try to cache manually change cache dir Trigger pipeline: test caching remove sccache dir Trigger pipeline: test caching remove uneeded args remove mozilla-actions/sccache-action, it doesn't work anyway Trigger pipeline: test caching docker layers manually set a better cache invalidation policy use cargo.lock for cache key better than toml files Trigger pipeline: local cache should work fix growing cache size issue Trigger pipeline: test after fixing growing cache size try to inject sccache into docker builds change key for docker caching debug sccache add sccache just command debug sccache env vars update rust wrapper env var remove sccache debug logs Trigger pipeline: test latest state include dev-tools dockerfile in creating cache key use cache map Trigger pipeline: test latest state try gha cache after letting gha set env vars automatically Trigger pipeline: test gha cache clean up after gha worked and try warp build cache Trigger pipeline: test gha warpbuild cache
aradwann
force-pushed
the
ci-docker-enhancement
branch
from
4ece340
to
7f25fbf
Compare
Closed
|
Hi @aradwann . Thank you so much for creating this PR. This LGTM! But i would love to wait for @slinkydeveloper to give his input on it :) |
jackkleeman
reviewed
Nov 19, 2024
docker/Dockerfile
Outdated
| @@ -52,4 +57,4 @@ COPY --from=builder /etc/ssl /etc/ssl | |||
| # useful for health checks | |||
| RUN apt-get update && apt-get install -y curl && rm -rf /var/lib/apt/lists/* | |||
| WORKDIR / | |||
| ENTRYPOINT ["/usr/local/bin/restate-server"] | |||
| ENTRYPOINT ["/usr/local/bin/restate-server"] | |||
There was a problem hiding this comment.
nit: can the file continue to end in a newline?
jackkleeman
approved these changes
Nov 19, 2024
|
@muhamadazmy @jackkleeman Thank you for the review 🚀🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that sccache report always says that it is not used,
and docker layers aren't cached too
In this PR, I made the following changes:
ACTIONS_CACHE_URLACTIONS_RUNTIME_TOKENshouldn't be set manually, it populated automatically by ghasccacheaction: Thesccacheaction was removed since it doesn't work with building a Docker image.sccachecache between Docker builds: by using reproducible-containers/buildkit-cache-dance@v3Performance Improvement
this could help resolve restatedev/dev-tools#7