Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[replit] switch taplo lsp to my fork #389

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

cdmistman
Copy link
Contributor

Why

fixes https://linear.app/replit/issue/DX-809/taplo-lsp-highlights-entire-file-for-single-schema-error

taplo in main has an error that results in poor error spans when there are unexpected properties in an object :(

see tamasfe/taplo#664 for more information

What changed

changed taplo to use my pr branch for the above pr

Test plan

  1. valid .replit file shows no lsp errors
  2. create unexpected properties in objects and note that the error spans are accurate

Rollout

Describe any procedures or requirements needed to roll this out safely (or check the box below)

  • This is fully backward and forward compatible

@cdmistman cdmistman requested a review from a team as a code owner August 30, 2024 00:26
@cdmistman cdmistman requested review from blast-hardcheese and removed request for a team August 30, 2024 00:26
@cdmistman cdmistman merged commit d5c961c into main Aug 30, 2024
1 check passed
@cdmistman cdmistman deleted the cad/fix-dotreplit-schema-errors-sucking branch August 30, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants