Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor installation test suite #20

Open
8 tasks
rensbaardman opened this issue Jun 11, 2019 · 0 comments
Open
8 tasks

Refactor installation test suite #20

rensbaardman opened this issue Jun 11, 2019 · 0 comments
Labels
test suite

Comments

@rensbaardman
Copy link
Owner

rensbaardman commented Jun 11, 2019 •
edited
Loading

  • move error filtering to test file (helps to be more explicit in expected errors)
  • maybe just checking for declared peerDependencies in package.json is more than enough for asserting peerDependencies have been declared (and npm install without them gives an error)
  • programmatically extract the peerDependency requirements - might change in the future
  • better error handling in run_shared_test_cases()
  • make sure .tmp-installation-tests-folder always gets erased (even if tests get aborted or fails)

When rewire gets updated:

  • drop fork rensbaardman/rewire requirement
  • add test for minimal peerDependency requirement
  • add test for @next peerDependency requirement
@rensbaardman rensbaardman added this to the future milestone Jun 11, 2019
@rensbaardman rensbaardman removed this from the future milestone Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rensbaardman