Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency dashboard issue out of sync, listing PRs as open when they are not #5668

Closed
ChristianMurphy opened this issue Mar 8, 2020 · 8 comments
Closed

Dependency dashboard issue out of sync, listing PRs as open when they are not #5668

ChristianMurphy opened this issue Mar 8, 2020 · 8 comments
Labels
core:dashboard Related to Dependency Dashboard functionality priority-2-high Bugs impacting wide number of users or very important features status:blocked Issue is blocked by another issue or external requirement type:bug Bug fix of existing functionality

Comments

@ChristianMurphy
Copy link
Contributor

ChristianMurphy commented Mar 8, 2020 •
edited
Loading

What Renovate type are you using?

Hosted renovate, with GitHub on https://github.com/Jasig/uPortal-start

Describe the bug

The dependency dashboard issue lists several PRs as open (unlinked) when they have not been opened.

uPortal-Project/uPortal-start#440

screenshot:

Screenshot_2020-03-08 Update Dependencies (Renovate Bot) · Issue #440 · Jasig uPortal-start

Did you see anything helpful in debug logs?

https://app.renovatebot.com/dashboard#github/Jasig/uPortal-start/149872446

To Reproduce

https://github.com/Jasig/uPortal-start
this may be related to rate limiting, previously they were in the rate limited section, they were manually checked, now have been caught in an intermediate state for several builds:

Additional context

Possibly related to #4803
@rarkins
Copy link
Collaborator

rarkins commented Mar 8, 2020

Can you tell me for the ones that aren't linked, do they:

  • all exist?
  • some exist but some don't?
  • none exist?

@ChristianMurphy
Copy link
Contributor Author

none exist

@rarkins rarkins added the type:bug Bug fix of existing functionality label Mar 8, 2020
@rarkins
Copy link
Collaborator

rarkins commented Mar 8, 2020

Thanks. I would like to see if it resets to correct on the next run too, i.e is it temporary or permanent.

@ChristianMurphy
Copy link
Contributor Author

Next run appears to have finished, https://app.renovatebot.com/dashboard#github/Jasig/uPortal-start/149878694
PRs and master issue are the same after.

@rarkins
Copy link
Collaborator

rarkins commented Mar 9, 2020

Seems like they're stuck in an "intermediate state" as you say. Converting all our return values/result values into TypeScript enums at the moment, after that we should hopefully catch the problem.

@rarkins rarkins added blocked priority-2-high Bugs impacting wide number of users or very important features labels Mar 9, 2020
@ChristianMurphy
Copy link
Contributor Author

Converting all our return values/result values into TypeScript enums at the moment, after that we should hopefully catch the problem.

👍
linking related PR #5664

@rarkins
Copy link
Collaborator

rarkins commented Mar 11, 2020

I'm working on a branch that should solve this once and forever, but so far it's like pulling on a thread that keeps going - changes needed in a lot of code.

@rarkins rarkins removed the blocked label Jun 18, 2020
@rarkins rarkins added status:blocked Issue is blocked by another issue or external requirement status:in-progress Someone is working on implementation and removed status:in-progress Someone is working on implementation labels Jan 12, 2021
@ChristianMurphy ChristianMurphy changed the title Master issue out of sync, listing PRs as open when they are not Dependency dashboard issue out of sync, listing PRs as open when they are not Jan 13, 2021
@rarkins
Copy link
Collaborator

rarkins commented Jun 7, 2021

This should be resolved in renovate@25.37.1

@rarkins rarkins closed this as completed Jun 7, 2021
@rarkins rarkins added the core:dashboard Related to Dependency Dashboard functionality label Jun 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
core:dashboard Related to Dependency Dashboard functionality priority-2-high Bugs impacting wide number of users or very important features status:blocked Issue is blocked by another issue or external requirement type:bug Bug fix of existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChristianMurphy @rarkins