Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): BundleAssets - extract i18n #4851

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix(ui): BundleAssets - extract i18n #4851

merged 1 commit into from
Nov 20, 2024

Conversation

vio
Copy link
Member

@vio vio commented Nov 20, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Enhanced internationalization support for asset management terminology, improving localization capabilities across the UI.
    • Added new constants for various asset-related terms and tooltips, providing clearer context for users.
  • Improvements

    • Updated components to utilize internationalization for labels and tooltips, ensuring adaptability for different languages.
    • Improved search functionality with localized placeholders in the asset bundle component.
  • Bug Fixes

    • Minor adjustments made to ensure the correct implementation of search functionality based on user interactions.

Copy link

coderabbitai bot commented Nov 20, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces several new constants for internationalization in the asset management components of the UI. New string constants are added in the asset-info.i18n.ts and bundle-assets.i18n.ts files, enhancing localization capabilities by providing translatable strings for asset-related terminology. The asset-info.tsx and bundle-assets.tsx files have been updated to utilize these new constants instead of hardcoded strings, improving adaptability for different languages. Additionally, the bundle-assets.utils.ts file has been modified to incorporate internationalized labels for filter options.

Changes

File Path Change Summary
packages/ui/src/components/asset-info/asset-info.i18n.ts Added constants for internationalization: ENTRY, INITIAL, CHUNK, CHUNK_TOOLTIP, ENTRYPOINT, FILE_TYPE, FILE_TYPE_TOOLTIP.
packages/ui/src/components/asset-info/asset-info.tsx Imported I18N module and replaced hardcoded strings with internationalized constants.
packages/ui/src/components/bundle-assets/bundle-assets.i18n.ts Added constants for internationalization: CHANGED, FILE_TYPE, CHUNKS, NO_CHUNK, ENTRY, INITIAL, CHUNK, OTHER.
packages/ui/src/components/bundle-assets/bundle-assets.tsx Updated import for search placeholder to use BUNDLE_ASSETS_I18N.SEARCH_PLACEHOLDER.
packages/ui/src/components/bundle-assets/bundle-assets.utils.ts Imported I18N module and updated filter labels to use internationalized constants.

Possibly related PRs

  • fix(ui): BundleAssets - add "No chunk" filter #4850: The addition of the NO_CHUNK_FILTER constant and its integration into the filtering logic for assets directly relates to the internationalization changes made in the main PR, as both involve enhancing the handling of asset-related terminology and filtering capabilities.

🐰 In the realm of assets, bright and clear,
New words for all, let’s give a cheer!
From “Entry” to “Chunk”, they dance and play,
With tooltips to guide, they light the way.
In every language, our assets will sing,
Localization magic, oh what joy it brings! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vio vio enabled auto-merge November 20, 2024 22:18
Copy link

relativeci bot commented Nov 20, 2024

#11696 Bundle Size — 380.81KiB (~-0.01%).

03cda3a(current) vs 2cf7ed9 master#11695(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Improvement 1 improvement
                 Current
#11696
     Baseline
#11695
Improvement  Initial JS 333.92KiB(~-0.01%) 333.93KiB
No change  Initial CSS 46.89KiB 46.89KiB
Change  Cache Invalidation 28.55% 28.53%
No change  Chunks 3 3
No change  Assets 4 4
Change  Modules 700(+0.14%) 699
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 39 39
No change  Duplicate Packages 1 1
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
#11696
     Baseline
#11695
Improvement  JS 333.92KiB (~-0.01%) 333.93KiB
No change  CSS 46.89KiB 46.89KiB

Bundle analysis reportBranch bundle-assets-i18nProject dashboard


Generated by RelativeCIDocumentationReport issue

@vio vio merged commit 6fca63b into master Nov 20, 2024
27 of 28 checks passed
@vio vio deleted the bundle-assets-i18n branch November 20, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant