Remove unpolarized probe from SA plot #151
Conversation
When Polarized and Unpolarized probes exist, Unpolarized probe is plotted in "SA" views as default view (log scale) such that the SA for polarized probes cannot be viewed. Removes this from the plot.
|
@purnimab - this PR seems to be based on a branch other than 'master'. Can you start a new PR with just the changes you've listed in this commit, but based on 'master'? |
|
Ah, I'm sorry, could it be because I haven't pulled from the main repo for
a while so it's just out of date?
…On Sat, Jun 25, 2022, 1:14 PM Brian Benjamin Maranville < ***@***.***> wrote:
@purnimab <https://github.com/purnimab> - this PR seems to be based on a
branch other than 'master'. Can you start a new PR with just the changes
you've listed in this commit, but based on 'master'?
—
Reply to this email directly, view it on GitHub
<#151 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADRHOJU7EK5LWZF2QEJ3PTTVQ45ADANCNFSM5ZYN4J4Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Ah - I think I was wrong. I saw a commit that looked like it came from a different branch, but github says your 'master' is just behind this 'master' by 6 commits, so the merge should work fine. |
|
Regarding this PR, does the SA plot still work when the datasets do not contain unpolarized? Wouldn't it be better to suppress the unpolarized plots when SA is requested rather than suppressing the SA? |
|
@pkienzle Since PolarizedNeutronProbe has it's own plot() function which does call plot_SA(), the SA plot still works for the polarized datasets. This should just suppress plotting the "default view" (unpolarized plot) for the unpolarized probe when requesting SA. |
|
|
When polarized and unpolarized Probes exist, unpolarized Probe is plotted in "SA" view as default view (log scale) such that the SA for polarized probes cannot be viewed. Removes this from the plot.