Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git auth not used #8

Open
Moulick opened this issue May 24, 2020 · 0 comments
Open

Git auth not used #8

Moulick opened this issue May 24, 2020 · 0 comments

Comments

@Moulick
Copy link

Moulick commented May 24, 2020

Hi, The secret provided in ClusterCap for authenticating against a private repo is not used.

postgres_cap.yaml
apiVersion: shipcaps.redradrat.xyz/v1beta1
kind: ClusterCap
metadata:
  name: postgres
spec:
  inputs:
    - key: fullnameOverride
      type: string
      targetId: fullnameOverride
    # - key: username
    #   type: string
    #   targetId: postgresqlUsername
    # - key: password
    #   type: string
    #   targetId: postgresqlPassword
    - key: dbname
      type: string
      targetId: postgresqlDatabase
    - key: storage
      type: string
      targetId: persistence.size
    - key: monitoringNamespace
      type: string
      targetId: metrics.serviceMonitor.namespace
  values:
    - targetId: metrics.enabled
      value: true
    - targetId: metrics.serviceMonitor.enabled
      value: true
    - targetId: serviceAccount.enabled
      value: true
    - targetId: image.tag
      value: 10.11.0
    - targetId: service.annotations
      value: 
        custom.service.annotation: "True"
  source:
    type: helmchart
    repo:
      uri: https://git.example.private/path/charts.git
      path: bitnami/postgresql
      ref: v1.0
      auth:
        username:
          secretKeyRef:
            name: gitlab-charts
            key: username
        password: 
          secretKeyRef:
            name: gitlab-charts
            key: password
postgres_app.yaml
apiVersion: shipcaps.redradrat.xyz/v1beta1
kind: App
metadata:
  name: emptyapi-v1-testdb-postgresql
spec:
  capRef: null
  clusterCapRef:
    kind: ClusterCap
    name: postgres
  values:
  - key: fullnameOverride
    value: emptyapi-v1-testdb-postgresql
  - key: dbname
    value: emptyapi-v1
  - key: storage
    value: 40Gi
  - key: monitoringNamespace
    value: default
output_helmrelease.yaml
apiVersion: helm.fluxcd.io/v1
kind: HelmRelease
metadata:
  creationTimestamp: "2020-05-24T10:22:53Z"
  generation: 1
  name: emptyapi-v1-testdb-postgresql
  namespace: default
  resourceVersion: "184130"
  selfLink: /apis/helm.fluxcd.io/v1/namespaces/default/helmreleases/emptyapi-v1-testdb-postgresql
  uid: 86fab28f-9da8-11ea-9bdd-0242ac110002
spec:
  chart:
    git: https://git.example.private/path/charts.git
    path: bitnami/postgresql
    ref: v1.0
  rollback: {}
  values:
    fullnameOverride: emptyapi-v1-testdb-postgresql
    image:
      tag: 10.11.0
    metrics:
      enabled: true
      serviceMonitor:
        enabled: true
        namespace: default
    persistence:
      size: 40Gi
    postgresqlDatabase: emptyapi-v1
    service:
      annotations:
        ontrack.hilti.com/cross-cluster-enabled: "True"
    serviceAccount:
      enabled: true

The expected spec should have been

spec:
  chart:
    git: https://git.example.private/path/charts.git
    path: bitnami/postgresql
    ref: v1.0
    secretRef:
      name: some-secret
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant