Better handle chain redirection detection

redirectionio · May 13, 2024 · 692a7b1 · 692a7b1
1 parent 085f5a1
commit 692a7b1
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/src/api/redirection_loop.rs b/src/api/redirection_loop.rs
@@ -96,16 +96,6 @@ impl RedirectionLoop {
             }
 
             if i > 1 {
-                // If the url cannot be parsed, let's treat it as a relative Url.
-                // Otherwise, we check if the corresponding domain is registered in the project.
-                if let Ok(url) = Url::parse(&current_url) {
-                    if !project_domains.is_empty() && !project_domains.contains(&url.host_str().unwrap().to_string()) {
-                        // The current url target a domain that is not registered in the project.
-                        // So we consider there is no redirection loop here.
-                        break;
-                    }
-                }
-
                 error = Some(RedirectionError::AtLeastOneHop);
             }
 
@@ -131,6 +121,16 @@ impl RedirectionLoop {
                 method: current_method.clone(),
             });
 
+            // If the url cannot be parsed, let's treat it as a relative Url.
+            // Otherwise, we check if the corresponding domain is registered in the project.
+            if let Ok(url) = Url::parse(&current_url) {
+                if !project_domains.is_empty() && !project_domains.contains(&url.host_str().unwrap().to_string()) {
+                    // The current url target a domain that is not registered in the project.
+                    // So we consider there is no redirection loop here.
+                    break;
+                }
+            }
+
             if i >= max_hops {
                 error = Some(RedirectionError::TooManyHops);
                 break;