Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing change in survey code #36

Closed
przemkalit opened this issue Nov 28, 2024 · 1 comment · Fixed by #38
Closed

Missing change in survey code #36

przemkalit opened this issue Nov 28, 2024 · 1 comment · Fixed by #38
Labels
bug Something isn't working

Comments

@przemkalit
Copy link
Contributor

przemkalit commented Nov 28, 2024

HI,

I've noticed that there was removed crucial change in the code inside survey.

regex_replace('default: ([^"].*)', 'default: "\\g<1>

It was in this commit: 8087e88

Edit. Ok I get it was bugged could you provide other solution to the #8?

@przemkalit przemkalit added the bug Something isn't working label Nov 28, 2024
@przemkalit
Copy link
Contributor Author

przemkalit commented Nov 29, 2024

Let me just mark one thing this change is breaking survey description:

If you have a description of a survey question like below:

please copy-paste here the job id.  You'll find a "JOBS / ########" it in the top-left area of job's page: the #s are the job id.

It will fail during the import.

question_description: "please copy-paste here the job id.  You""ll find a "JOBS / ########" it in the top-left area of job""s page: the #s are the job id."

I think you see the quotes inside the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant