Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double quote issue #2

Closed
przemkalit opened this issue Oct 7, 2024 · 0 comments · Fixed by #3
Closed

Double quote issue #2

przemkalit opened this issue Oct 7, 2024 · 0 comments · Fixed by #3
Labels
bug Something isn't working

Comments

@przemkalit
Copy link
Contributor

przemkalit commented Oct 7, 2024

Summary

I've discovered that the commit 1dc1820 introduces a bug where if there is a " inside the survey question, it will break the YAML.

Shouldn't there be an error related to broken YAML in the filetree_read?
While debugging the issue, we had to review the controller_templates variable.

Issue Type

  • Bug Report

Ansible, Collection, Controller details

N/A

OS / ENVIRONMENT

N/A

Desired Behavior

Job template is properly exported.

Actual Behavior

Broken yaml:

survey_spec_contents:
  description: ""
  name: ""
  spec:
    - choices: ""
      default: ""
      max: 1024
      min: 0
      new_question: true
      question_description: "Comma separated list of lint rules to skip. Both specific checks and general rules can be skipped, i.e.: "name[missing],fqcn"."
      question_name: Rules to skip
      required: false
      type: text
      variable: skip_rules

STEPS TO REPRODUCE

  1. Create JT with survey that is having question with double quote inside.
  2. Export the JT.
  3. Valid Yaml.
@przemkalit przemkalit added the bug Something isn't working label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant