rpc: add new rpc call for mirroring #2875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
rewantsoni
force-pushed
the
mirroring-rpc
branch
3 times, most recently
from
3a5aad6
to
4950f96
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
rewantsoni
force-pushed
the
mirroring-rpc
branch
7 times, most recently
from
f228a04
to
e069e9a
Compare
openshift-merge-robot
added
the
needs-rebase
nb-ohad
requested changes
Nov 11, 2024
rewantsoni
force-pushed
the
mirroring-rpc
branch
from
e069e9a
to
be79221
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rewantsoni The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
removed
the
needs-rebase
rewantsoni
force-pushed
the
mirroring-rpc
branch
2 times, most recently
from
8d7cbb8
to
e250ada
Compare
nb-ohad
requested changes
Nov 12, 2024
rewantsoni
force-pushed
the
mirroring-rpc
branch
from
e250ada
to
c85b0ad
Compare
nb-ohad
requested changes
Nov 13, 2024
rewantsoni
force-pushed
the
mirroring-rpc
branch
4 times, most recently
from
6208c00
to
5a38c09
Compare
rewantsoni
force-pushed
the
mirroring-rpc
branch
from
5a38c09
to
064fb50
Compare
openshift-merge-robot
added
the
needs-rebase
rewantsoni
force-pushed
the
mirroring-rpc
branch
from
064fb50
to
0a3a397
Compare
openshift-merge-robot
removed
the
needs-rebase
rewantsoni
force-pushed
the
mirroring-rpc
branch
from
0a3a397
to
646eff2
Compare
openshift-merge-robot
added
the
needs-rebase
rewantsoni
force-pushed
the
mirroring-rpc
branch
from
646eff2
to
4542ed1
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/retest-required |
1 similar comment
|
/retest-required |
openshift-merge-robot
added
the
needs-rebase
Signed-off-by: Rewant Soni <resoni@redhat.com>
Signed-off-by: Rewant Soni <resoni@redhat.com> add generated changes Signed-off-by: Rewant Soni <resoni@redhat.com>
rewantsoni
force-pushed
the
mirroring-rpc
branch
from
4542ed1
to
17fe469
Compare
openshift-merge-robot
removed
the
needs-rebase
rewantsoni
force-pushed
the
mirroring-rpc
branch
2 times, most recently
from
efc052d
to
967006c
Compare
nb-ohad
requested changes
Nov 25, 2024
| } | ||
|
|
||
| message BlockPoolInfoError { | ||
| ErrorCode code = 1; |
There was a problem hiding this comment.
How come both the blockpoolinfo and the storageclientinfo using the same error code enum?
Signed-off-by: Rewant Soni <resoni@redhat.com>
rewantsoni
force-pushed
the
mirroring-rpc
branch
from
967006c
to
6d895fa
Compare
openshift-merge-bot
bot
merged commit 6d895fa
into
red-hat-storage:main
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two rpc calls required for setting up mirroring for blockpool and radosnamespace