Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CONFIG object for better maintainability #3

Open
adithyaakrishna opened this issue Oct 1, 2024 · 2 comments
Open

Refactor CONFIG object for better maintainability #3

adithyaakrishna opened this issue Oct 1, 2024 · 2 comments
Assignees

Comments

@adithyaakrishna
Copy link
Contributor

The CONFIG object in config.ts contains configuration for different encryption algorithms. Refactoring this object could improve maintainability and readability.

Tasks:

  1. Create separate configuration objects for each encryption algorithm (chacha20, aes-256-ctr, aes-128-ctr).
  2. Use a factory function or a class to generate these configuration objects.
  3. Implement type checking for the configuration objects.
  4. Add comments explaining the purpose of each configuration property.
  5. Consider using TypeScript interfaces to define the structure of the configuration objects.

Refactoring the CONFIG object will make it easier to add new encryption algorithms in the future and improve code organization.

Contributors: Please note that by submitting a pull request, you are agreeing to accept and sign the Contributor License Agreement (CLA) found at https://github.com/reclaimprotocol/.github/blob/main/CLA.md

@varun-doshi
Copy link
Contributor

I'd like to take this up

@adithyaakrishna
Copy link
Contributor Author

@varun-doshi Assigned to you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants