Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactEvent -> React.Event in docs #831

Open
benbellick opened this issue Apr 15, 2024 · 2 comments · May be fixed by #864
Open

ReactEvent -> React.Event in docs #831

benbellick opened this issue Apr 15, 2024 · 2 comments · May be fixed by #864

Comments

@benbellick
Copy link

It seems a lot of places in the docs say ReactEvent, when they mean to say React.Event,
e.g.:

/* App.re */
/* CORRECT! This code is bug-free. 👍 */
[@react.component]
let make = () => {
  let (name, setName) = React.useState(() => "John");
  <input
    type_="text"
    value={name}
    onChange={
      event => {
        let value = ReactEvent.Form.target(event)##value;
        setName(_ => value)
      }
    }
  />;
};
@benbellick
Copy link
Author

Happy to fix this one myself, but just wanted to get it down before I forget!

@davesnx
Copy link
Member

davesnx commented Apr 15, 2024

Good catch, I forgot to update the docs references with the last update.

@davesnx davesnx linked a pull request Nov 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants