Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Polling mode doesn't work on osx #40

Open
jaredly opened this issue Sep 19, 2016 · 13 comments
Open

[bug] Polling mode doesn't work on osx #40

jaredly opened this issue Sep 19, 2016 · 13 comments

Comments

@jaredly
Copy link
Contributor

jaredly commented Sep 19, 2016

rebel -P, and then I change one of my source files, and it doesn't recompile. Am I missing a step?
I have to kill & re-run rebel for my stuff to be recompiled

@vramana
Copy link
Contributor

vramana commented Sep 19, 2016

@jaredly It works for fine for me. Can you try it on different project and see if that makes any difference?

@jaredly
Copy link
Contributor Author

jaredly commented Sep 19, 2016

mkdir -p something/src
cd something
echo "{}" > package.json
echo 'print_endline "hello";' > src/hello.re
rebel -P # in a diff tab
./_build/src/app.out # `hello`
echo 'print_endline "hello all";' > src/hello.re
./_build/src/app.out # `hello`

@jaredly
Copy link
Contributor Author

jaredly commented Sep 19, 2016

13:23:34 rsn/something 0 $ rebel -P
*** jenga: [79301] root=/Users/jared/clone/rsn/something, sys=Darwin, j=1, f=1 (NO_VERSION_UTIL)
*** jenga: 6/6 targets are up to date
*** jenga: done (#1, 107ms, heap=7.35156m, stat=20, digest=5, ls=1, db-save=0) -- HURRAH
*** jenga: todo: 0 (6 / 6) j=0+0 con=6 save=0 act=3, finished
*** jenga: polling for filesystem changes

and it never does anything else

@jaredly
Copy link
Contributor Author

jaredly commented Sep 19, 2016

except for running GC for some reason ??

@vramana
Copy link
Contributor

vramana commented Sep 19, 2016

cc @chenglou I think polling mode worked for you. Could it be a jenga bug? I can't think of any reasons.

@chenglou
Copy link
Collaborator

chenglou commented Sep 19, 2016

Never tried polling actually. Just assumed it didn't work on OS X. I think OS X isn't officially supported for polling. cc @bsansouci

@bsansouci
Copy link
Contributor

Jenga uses a linux watcher (inotify I think) so no polling on osx :/

@chenglou
Copy link
Collaborator

Time to replace it with watchman =)

@jaredly
Copy link
Contributor Author

jaredly commented Sep 19, 2016

boo :/ who cares if its fast if it doesn't work

@bsansouci
Copy link
Contributor

If you want a bad replacement for this that only depends on node: https://github.com/bsansouci/tapknight/blob/6c3d7371a5c67209d75ee6bc309db755d8cf4081/watch.js
I could never figure out watchman lol

@jaredly
Copy link
Contributor Author

jaredly commented Sep 19, 2016

right watchman has caused me so much grief

@jaredly
Copy link
Contributor Author

jaredly commented Sep 19, 2016

and watchman was developed for FacebookScale™ and so is probs overkill for anything that's not the fb monorepo :P

@jaredly jaredly changed the title [bug] Polling mode doesn't work [bug] Polling mode doesn't work on osx Sep 20, 2016
@jaredly
Copy link
Contributor Author

jaredly commented Sep 20, 2016

made a note there janestreet/jenga#30
but maybe this is another reason to just have a wrapper around jenga that

  • gets multiple indepedant build targets working (with diff backends, flags, etc)
  • makes file watching work cross-platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants