Skip to content
This repository has been archived by the owner on Mar 30, 2022. It is now read-only.

Fix Typescript Errors #145

Open
flyingcircle opened this issue Mar 16, 2021 · 8 comments
Open

Fix Typescript Errors #145

flyingcircle opened this issue Mar 16, 2021 · 8 comments

Comments

@flyingcircle
Copy link
Contributor

I have recently converted all of the code to typescript. It should still compile just fine, but it would be nice to have the demo app be a good check on the correctness of the developer experience of using the library.

There are a lot of hanging typescript errors. This would be to go through and fix them so that tsc passes cleanly.

@khushal87
Copy link
Member

I would like to take up this, and fix the issues.

@khushal87
Copy link
Member

@flyingcircle Can you assign me this issue?

@khushal87
Copy link
Member

The rest of the issues are coming up from the package react-native-elements therefore this can be closed. @flyingcircle

@flyingcircle
Copy link
Contributor Author

I'd prefer this stay open. If there's an issue showing up here, then we need a ticket written in RNE for it to be solved.

@khushal87
Copy link
Member

khushal87 commented Mar 28, 2021

The ticket is already there. I am working on the potential fixes of the same in the package. Reference - react-native-elements/react-native-elements#2870 @flyingcircle

@flyingcircle
Copy link
Contributor Author

Great. Let's keep the ticket open here so that when it's done, we can validate that it's fixed here before closing.

@khushal87
Copy link
Member

Yes. @flyingcircle

@khushal87
Copy link
Member

I will try to handle the strict mode issues too soon. @flyingcircle Can I do so?

@khushal87 khushal87 removed their assignment Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants