Use the ReactAppDependencyProvider in the template #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary This change depends on facebook/react-native#47761. It uses the new pod, which is compatible with swift, to inject the AppDependency in React Native ## Changelog [iOS][Breaking] - Use the new ReactAppDependencyProvider pod in AppDelegate ## Test Plan: Tested with a nightly app with an external dependency, with both static libraries and dynamic frameworks
|
facebook/react-native#47761 looks good. @cipolleschi will you land this once the RN change lands in main? |
blakef
approved these changes
Nov 20, 2024
cipolleschi
deleted the
cipolleschi/use-the-reactappdependencyprovider
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change depends on facebook/react-native#47761.
It uses the new pod, which is compatible with swift, to inject the AppDependency in React Native
Changelog
[iOS][Breaking] - Use the new ReactAppDependencyProvider pod in AppDelegate
Test Plan:
Tested with a nightly app with an external dependency, with both static libraries and dynamic frameworks