-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Snap Kit React Native #737
base: main
Are you sure you want to change the base?
Adding Snap Kit React Native #737
Conversation
Updating the react-native-libraries.json file to add info for Snap Kit React Native npm repo. Pair: @safaiyeh
Hey @Simek we wanted to launch Snap's official RN library on directory. Github cannot be public yet could it link to the NPM package |
Hello guys, unfortunately we do not have a support for closed-source packages at this moment. The GitHub repo and data extracted from the GitHub API about the repo and package are essential for getting metadata, scoring entry and it is a source of most of data which is displayed at the end. |
Thanks @Simek there is a plan to open source it at some point. Will leave it to @ramanpreetSinghKhinda to update this addition when Snap gets it open sourced |
@ramanpreetSinghKhinda Unfortunately no, as you can see it breaks the validation and it would break the data fetch and the deploy. There is no way around, besides refactoring a bunch of code and changing scoring methods to accommodate the lack of essential so far data. |
@Simek so will a private Github repo link work? If not, we can update this PR once we open source. |
It will only work if you provide Feel free to update the PR when the library will be open sourced and re-request the review. π |
π Why & how
Add a new library https://www.npmjs.com/package/@snapchat/snap-kit-react-native
Pair: @safaiyeh
β Checklist
react-native-libraries.json
react-native-libraries.json