-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(interview): Project visibility [1] #1121
base: interview
Are you sure you want to change the base?
Conversation
199863c
to
be2dea7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the implementation so far looks good.
Our use case would probably require the site permissions as well.
Could we not make a rule based on user.role.member
and project.owner.role.member
to filter a bit for Site
already? That when the current user is also a member of the same site as the project.owner?
Yes, of course. But then you cannot create template projects for all sites right? We could add a choice |
Yeah maybe, but as long as |
This PR adds a new
visibility
field toProject
.private
is the current behavior,internal
allows everybody to access the project like aguest
(read only). I added a choice field in case we need a public choice in the future.At on point we probably want to restrict projects to groups/sites but this should be better done using yet another field.