Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure sparsecoding/data #77

Closed
belsten opened this issue Nov 20, 2024 · 1 comment
Closed

Restructure sparsecoding/data #77

belsten opened this issue Nov 20, 2024 · 1 comment

Comments

@belsten
Copy link
Collaborator

belsten commented Nov 20, 2024

Right now, sparsecoding/data contains dictionary loading code, dictionary files, and transform code. This makes it less intuitive to use as code to transform data and load specific types of data are under the same umbrella.

I propose consolidating code such that there are sparsecoding/data/dictionaries.py which manages the loading of dictionaries (what is currently in sparsecoding/data/utils.py which can also use documentation), and sparsecoding/data/datasets.py which manages the load of datasets (contains the code in sparsecoding/data/datasets/bars.py and sparsecoding/data/datasets/field.py.

A sparsecoding/transforms directory can then be made that contains the all of the transform .pys. Additionally

This should probably be done after @HarrisonSantiago merges his contributions to the whitening code. Also, we'll have to update the example notebooks to reflect these new changes.

@belsten belsten closed this as completed Nov 28, 2024
@belsten
Copy link
Collaborator Author

belsten commented Nov 28, 2024

closed with #76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant