Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate implementations in job service and priority resolver #601

Open
2 tasks
irainia opened this issue Sep 15, 2022 · 0 comments
Open
2 tasks

Remove duplicate implementations in job service and priority resolver #601

irainia opened this issue Sep 15, 2022 · 0 comments
Labels
refactor Internal code improvement
Milestone
Code CleanUp

Comments

@irainia
Copy link
Member

irainia commented Sep 15, 2022

Description
This issue is included in this discussion. Under job service and priority resolver, there's a duplicated populateDownstreamDAGs in job/service.go is too tied up with Airflow scheduler. The logic itself is quite similar to buildMultiRootDependencyTree in job/priority_resolver.go.

Acceptance Criteria

  • no duplicate implementation between job service and priority resolver

Tech Details

  • remove one of the two implementation
@irainia irainia added the refactor Internal code improvement label Sep 15, 2022
@irainia irainia added this to the Code CleanUp milestone Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Internal code improvement
Projects
None yet
Milestone
Code CleanUp
Development

No branches or pull requests
1 participant
@irainia