some tiny improvements and way more comments #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lurch
reviewed
Oct 30, 2024
lurch
reviewed
Oct 30, 2024
| * @param vaddr Virtual address. | ||
| * @param size Size of the area to check. | ||
| * @param uninitialized Flag indicating if the area is uninitialized. | ||
| * @param ar Reference to an address_range that will be set on success. |
There was a problem hiding this comment.
"Reference to the valid_range that the provided (addr + size) fits inside" ?
lurch
reviewed
Oct 30, 2024
lurch
reviewed
Oct 30, 2024
lurch
reviewed
Oct 30, 2024
| * | ||
| * @param entries Vector of ELF-32 program header entries. | ||
| * @param valid_ranges Valid address ranges. | ||
| * @param pages Map of pages with their fragments. |
There was a problem hiding this comment.
"Reference to the page fragments map", to make it more obvious that this is "the page fragments map" to which the @brief is referring?
lurch
reviewed
Oct 30, 2024
lurch
reviewed
Oct 30, 2024
Comment on lines
+342
to
+343
| * @param package_addr Optional packaging address. | ||
| * @param abs_block_loc Optional absolute block location. |
There was a problem hiding this comment.
Same questions about "Optional"
Co-authored-by: will-v-pi <108662275+will-v-pi@users.noreply.github.com>
lurch
reviewed
Nov 2, 2024
Signed-off-by: Simon Waldherr <git@simon.waldherr.eu>
Signed-off-by: Simon Waldherr <git@simon.waldherr.eu>
|
So, what's the status? Would you like any other changes? |
|
There are a couple of unresolved comments from @lurch still - but once those are resolved this can be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull request changed to "develop"-branch as requested by @will-v-pi (#160)