CMakeLists.txt: also link to additional package-config libraries #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LibUSB might specify additional libraries to link to via package-config (i.e. libatomic where this isn't a builtin [1]). These are correctly discovered by the call to pkg_check_modules and put into the PC_LIBUSB_LIBRARIES variable but then never added to the actual linking step. Fix that by additionally adding them behind the libusb library discovered by the find_library call(). [1] https://github.com/libusb/libusb/blob/v1.0.27/configure.ac#L184
will-v-pi
requested changes
Aug 30, 2024
There was a problem hiding this comment.
I think it would be better to make this change in cmake/FindLIBUSB.cmake and append PC_LIBUSB_LIBRARIES to the LIBUSB_LIBRARIES variable, rather than using PC_LIBUSB_LIBRARIES in the main CMakeLists.txt
Also, could you target this at the develop branch instead of master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LibUSB might specify additional libraries to link to via package-config (i.e. libatomic where this isn't a builtin [1]). These are correctly discovered by the call to pkg_check_modules and put into the PC_LIBUSB_LIBRARIES variable but then never added to the actual linking step.
Fix that by additionally adding them behind the libusb library discovered by the find_library call().
[1] https://github.com/libusb/libusb/blob/v1.0.27/configure.ac#L184