Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version number to picotool output #132

Open
jtraister opened this issue Mar 27, 2024 · 3 comments
Open

Add version number to picotool output #132

jtraister opened this issue Mar 27, 2024 · 3 comments

Comments

@jtraister
Copy link

jtraister commented Mar 27, 2024

Please add a bi_program_version_string() call with the version number. Right now I have to rely on build date to determine the difference between binaries, but that's not great.

@lurch
Copy link
Contributor

lurch commented Mar 27, 2024

I guess this sort of relates to #113 ?

@jtraister
Copy link
Author

I think so, just more info available about the binary.

@fduxiao
Copy link

fduxiao commented Mar 28, 2024

I'm not sure where to get the version string, but I wrote this adding the git tag as version. If HEAD is tagged, then the tag is used for version; otherwise, git commit hash is used. Is this reasonable?

What else is needed? I can add all these to binary information and make a pull request then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants