-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Primitives & BFS performance improvements #4751
base: branch-24.12
Are you sure you want to change the base?
Conversation
…to enh_graph_creation
…ter supported by per_v_transform_reduce_if_outgoing_e)
…nce measurement code
…locator (this might be a too low level trick to be merged into the cugraph proper)
…to enh_prim_perf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor comments.
@@ -369,7 +485,7 @@ create_graph_from_partitioned_edgelist( | |||
if (edge_partition_edgelist_edge_ids) { element_size += sizeof(edge_id_t); } | |||
if (edge_partition_edgelist_edge_types) { element_size += sizeof(edge_type_t); } | |||
auto constexpr mem_frugal_ratio = | |||
0.25; // if the expected temporary buffer size exceeds the mem_frugal_ratio of the | |||
0.05; // if the expected temporary buffer size exceeds the mem_frugal_ratio of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something we should look at updating universally, or is this still a tunable we should continue to evaluate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may individually tune this, but I think we may eventually create a (or few) separate file storing every tunable parameters.
@@ -0,0 +1,738 @@ | |||
/* | |||
* Copyright (c) 2021-2024, NVIDIA CORPORATION. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this just be 2024?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, and I am wondering whether we should keep this file or just delete it. We already have BFS tests, this is a bit redundant.
…to enh_prim_perf
…to enh_prim_perf
…to enh_prim_perf
…o enh_prim_perf
This PR includes multiple updates to cut peak memory usage in graph creation and improve performance of BFS on scale-free graphs.