Linux post libs comments and specs #19682
Draft
+1,528
−539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thank you @h00die for adding documentation and specs. I just added a couple of comments.
| def installed_package_version(package) | ||
| info = get_sysinfo | ||
|
|
||
| if ['debian', 'ubuntu'].include?info[:distro] |
There was a problem hiding this comment.
Just for consistency:
Suggested change
| if ['debian', 'ubuntu'].include?info[:distro] | |
| if ['debian', 'ubuntu'].include?(info[:distro]) |
| return Rex::Version.new(package_version) | ||
| elsif ['redhat', 'fedora'].include?(info[:distro]) | ||
| package_version = cmd_exec("rpm -q #{package}") | ||
| return nil if package_version.include?('is not installed') |
There was a problem hiding this comment.
I haven't tested it, but I'm wondering if rpm returns a message in English on a non-English installation.
This also applies to the system commands called in this method.
|
Appreciate, I'm going to get specs working for all the linux post libs before putting this up for official review. Good question about language though |
jvoisin
reviewed
Nov 29, 2024
| info = get_sysinfo | ||
|
|
||
| if ['debian', 'ubuntu'].include?info[:distro] | ||
| package_version = cmd_exec("dpkg -l #{package} | grep \'^ii\'") |
There was a problem hiding this comment.
Suggested change
| package_version = cmd_exec("dpkg -l #{package} | grep \'^ii\'") | |
| package_version = cmd_exec("dpkg-query -f='${Version}' -W #{package}") |
This will directly output the version of the package if it's installed
| package_version = package_version.match(/Version\s+:\s+(.+)/)[1] | ||
| return Rex::Version.new(package_version) | ||
| else | ||
| vprint_error('installed_package_version is being called on an unsupported OS') |
There was a problem hiding this comment.
Suggested change
| vprint_error('installed_package_version is being called on an unsupported OS') | |
| vprint_error("installed_package_version is being called on an unsupported OS: #{info['distro'}") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things for linux post libs:
packagesmodule which can be used to check what version of a package is installed. Ubuntu needrestart LPE (CVE-2024-48990) #19676 (comment)