Allow Setting Window Title #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphamorim
reviewed
Nov 20, 2024
rio-backend/src/config/window.rs
Outdated
| @@ -57,6 +57,8 @@ pub struct Window { | |||
| pub decorations: Decorations, | |||
| #[serde(default = "bool::default", rename = "macos-use-unified-titlebar")] | |||
| pub macos_use_unified_titlebar: bool, | |||
| #[serde(skip_serializing)] | |||
| pub title: Option<String>, | |||
There was a problem hiding this comment.
can we rename it for title_placeholder or initial_title ?
|
Overall it looks good! thanks for the PR @xsadia I appreciate! Would you mind also to include it in the docs? |
Absolutely, I'll update the docs as well shortly! |
|
@raphamorim anything else you'd like me to change just let me know! |
|
Thank you @xsadia 🙏 ⭐ |
raphamorim
reviewed
Nov 20, 2024
rio-backend/src/config/window.rs
Outdated
| @@ -57,6 +57,8 @@ pub struct Window { | |||
| pub decorations: Decorations, | |||
| #[serde(default = "bool::default", rename = "macos-use-unified-titlebar")] | |||
| pub macos_use_unified_titlebar: bool, | |||
| #[serde(skip_serializing)] | |||
There was a problem hiding this comment.
just one small thing: add rename = "initial-title"
|
@xsadia feel free to join our discord :) https://discord.gg/zRvJjmKGwS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for specifying a custom window title using the --title argument in the CLI. This feature allows users to define a specific name for the window, improving usability in multi-window setups and enabling better integration with window managers.
Default window title
Custom name with
--titleflagcloses #405