Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added some new things #3

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

dhlalit11
Copy link

added scale_start, volume control sample, changed version number

sets debounce time to 100 by raphaelyancey, simplifying  setting counter params by  raphaelyancey, added scale_start param for self.counter by me
added volume control with alsaaudio sample by me
updated version number to match changes
added info for scale_start
@raphaelyancey
Copy link
Owner

Thanks for the PR @dhlalit11.

I think the lib should stay agnostic of its use cases, but indeed the volume control is a classic. Maybe put it as the first example in an example/ directory?

Regarding scale_start, it can be more generic (not only for the scale mode) and #5 should do the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants