Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logging basicConfig from gnews.py #91

Open
babatonga opened this issue Apr 18, 2024 · 1 comment
Open

Remove logging basicConfig from gnews.py #91

babatonga opened this issue Apr 18, 2024 · 1 comment

Comments

@babatonga
Copy link

In the current implementation of gnews.py, the logging basicConfig is being set. However, this can lead to unintended consequences when GNews is used as a module within another application. It alters the entire configuration of the logging module, potentially conflicting with the main application's logging setup.

To address this issue and ensure better compatibility and modularity, it's advisable to remove the logging basicConfig from gnews.py. Instead, users can configure logging within their main application, allowing for better control and isolation of logging configurations. This change will prevent any interference with the main application's logging setup when using GNews as a module.

mengelkampIT@3c19c26

@ikubaysan
Copy link

ikubaysan commented Jun 12, 2024

Please make this change, this has caused me a headache pinpointing why my application was producing duplicate logs.
All that needs to be done is remove the logging.basicConfig() call from gnews.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants