Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register BaseInterfaces.jl? #48

Closed
MilesCranmer opened this issue Jun 30, 2024 · 3 comments
Closed

Register BaseInterfaces.jl? #48

MilesCranmer opened this issue Jun 30, 2024 · 3 comments

Comments

@MilesCranmer
Copy link
Contributor

I thought BaseInterfaces.ArrayInterface looked pretty useful and wanted to add it to my test suite for DynamicQuantities for testing QuantityArray. However it looks like it's unregistered at the moment. Is this something on the roadmap or is BaseInterfaces intended only as an example?
@rafaqz
Copy link
Owner

rafaqz commented Jun 30, 2024

It's meant to be registered, I just haven't had time to finish it (PhD + too many other packages...). Im not sure when I will have time either, definitely not in the next 4 months.

But if you have time to polish it up a bit and double check it all makes sense I can make time to review.

@MilesCranmer
Copy link
Contributor Author

No rush! For me #47 is much more important/timely, having BaseFeatures would just be gravy on top.

@rafaqz rafaqz mentioned this issue Jul 15, 2024
Open
5 tasks
@rafaqz
Copy link
Owner

rafaqz commented Aug 9, 2024

BaseInterfaces.jl is now registered :)

@rafaqz rafaqz closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rafaqz @MilesCranmer