Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interfaces.test(MyInterface{:optional_cond}) only checks optional_cond? #21

Open
gdalle opened this issue Oct 2, 2023 · 3 comments
Open

Comments

@gdalle
Copy link
Collaborator

gdalle commented Oct 2, 2023

I initially expected it to test all the mandatory conditions by default

@gdalle gdalle changed the title Interfaces.test(MyInterface{:optional_cond}) only checks the one condition Interfaces.test(MyInterface{:optional_cond}) only checks optional_cond Oct 2, 2023
@gdalle gdalle changed the title Interfaces.test(MyInterface{:optional_cond}) only checks optional_cond Interfaces.test(MyInterface{:optional_cond}) only checks optional_cond? Oct 2, 2023
@rafaqz
Copy link
Owner

rafaqz commented Oct 4, 2023

I had the exact same thought when I read it the other day.

I guess it should always test them all? Maybe the thinking was to cut down test time, but it doesn't make sense to run the optional ones without the mandaory ones really

@gdalle
Copy link
Collaborator Author

gdalle commented Jan 3, 2024

When writing GraphsInterfaceChecker I definitely wanted this to test mandatory parts too

@rafaqz
Copy link
Owner

rafaqz commented Jan 3, 2024

For sure! A PR will be merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants